Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ISIN Faker for finance module #152

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Add ISIN Faker for finance module #152

merged 3 commits into from
Sep 29, 2023

Conversation

Dejiah
Copy link
Contributor

@Dejiah Dejiah commented Sep 28, 2023

This PR contributes the proposed ISIN faker from issue #151:

  • It adds a new faker Isin, that generates valid ISINs.
  • Updates tests, documentation and examples to include the new faker.
  • Bumps the version to 2.10.0

@Dejiah Dejiah changed the title Added ISIN Faker for finance module Add SIN Faker for finance module Sep 28, 2023
@Dejiah Dejiah changed the title Add SIN Faker for finance module Add ISIN Faker for finance module Sep 28, 2023
@cksac cksac merged commit df9250c into cksac:master Sep 29, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dejiah @cksac